Broken logo 'src' in masthead for Galaxy 16.07 served from subdirectory

classic Classic list List threaded Threaded
3 messages Options
| Threaded
Open this post in threaded view
|

Broken logo 'src' in masthead for Galaxy 16.07 served from subdirectory

Peter Briggs
Dear developers

Since upgrading to release_16.07 I've noticed a broken link to the
masthead icon (i.e. the Galaxy logo 'galaxyIcon_noText.png') in our
local Galaxy installations, which are all served from subdirectories of
the webserver, e.g.

https://centaurus.itservices.manchester.ac.uk/galaxy/

The icon is visible when this URL is visited but appears to be broken
when using parts of Galaxy served from their own subdirectories e.g. the
login page (under
https://centaurus.itservices.manchester.ac.uk/galaxy/user/login?...) or
the admin interface
(https://centaurus.itservices.manchester.ac.uk/galaxy/admin).

At the top level the logo <img> "src" is points correctly to
"/galaxy/static/images/galaxyIcon_noText.png"; in the subdirs
(users,admin etc) it points to
"../../../static/images/galaxyIcon_noText.png" (which cannot be loaded).

As far as I can work out, in 16.07 the "src" location is generated from
templates/webapps/galaxy/galaxy.masthead.mako, but takes its value from
the 'logo_src' parameter that is set in
lib/galaxy/managers/configuration.py:

...
     # TODO: this doesn't seem right
    'logo_url'                  : lambda i, k, **c: self.url_for( i.get(
k, '/' ) ),
    'logo_src'                  : lambda i, k, **c: self.url_for(
'/static/images/galaxyIcon_noText.png' ),
...

However I have no idea how to try and fix it - presumably it needs to
incorporate the proxy-prefix setting somehow. (Btw the 'logo_url' does
seem to point to the correct location however.)

Can someone suggest a fix?

Thanks

Peter

--
Peter Briggs [hidden email]
Bioinformatics Core Facility University of Manchester
B.1083 Michael Smith Bldg Tel: (0161) 2751482
___________________________________________________________
Please keep all replies on the list by using "reply all"
in your mail client.  To manage your subscriptions to this
and other Galaxy lists, please use the interface at:
  https://lists.galaxyproject.org/

To search Galaxy mailing lists use the unified search at:
  http://galaxyproject.org/search/mailinglists/
| Threaded
Open this post in threaded view
|

Re: Broken logo 'src' in masthead for Galaxy 16.07 served from subdirectory

Saskia Hiltemann
hmm, I now remember having same thing when I first upgraded, I changed a
line in galaxy.masthead.mako:

--- a/templates/webapps/galaxy/galaxy.masthead.mako
+++ b/templates/webapps/galaxy/galaxy.masthead.mako
@@ -24,7 +24,7 @@
             'terms_url'                 : app.config.get("terms_url", ""),
             'allow_user_creation'       : app.config.allow_user_creation,
             'logo_url'                  : h.url_for(app.config.get(
'logo_url', '/')),
-            'logo_src'                  : h.url_for( app.config.get(
'logo_src', '../../../static/images/galaxyIcon_noText
+            'logo_src'                  : h.url_for( app.config.get(
'logo_src', '/static/images/galaxyIcon_noText.png' )
             'is_admin_user'             : trans.user_is_admin(),
             'active_view'               : active_view,
             'ftp_upload_dir'            :
app.config.get("ftp_upload_dir",  None),
@@ -78,4 +78,4 @@

Does this help at all?

Saskia



On 08-12-16 14:04, Peter Briggs wrote:

> Dear developers
>
> Since upgrading to release_16.07 I've noticed a broken link to the
> masthead icon (i.e. the Galaxy logo 'galaxyIcon_noText.png') in our
> local Galaxy installations, which are all served from subdirectories
> of the webserver, e.g.
>
> https://centaurus.itservices.manchester.ac.uk/galaxy/
>
> The icon is visible when this URL is visited but appears to be broken
> when using parts of Galaxy served from their own subdirectories e.g.
> the login page (under
> https://centaurus.itservices.manchester.ac.uk/galaxy/user/login?...)
> or the admin interface
> (https://centaurus.itservices.manchester.ac.uk/galaxy/admin).
>
> At the top level the logo <img> "src" is points correctly to
> "/galaxy/static/images/galaxyIcon_noText.png"; in the subdirs
> (users,admin etc) it points to
> "../../../static/images/galaxyIcon_noText.png" (which cannot be loaded).
>
> As far as I can work out, in 16.07 the "src" location is generated
> from templates/webapps/galaxy/galaxy.masthead.mako, but takes its
> value from the 'logo_src' parameter that is set in
> lib/galaxy/managers/configuration.py:
>
> ...
>     # TODO: this doesn't seem right
>    'logo_url'                  : lambda i, k, **c: self.url_for(
> i.get( k, '/' ) ),
>    'logo_src'                  : lambda i, k, **c: self.url_for(
> '/static/images/galaxyIcon_noText.png' ),
> ...
>
> However I have no idea how to try and fix it - presumably it needs to
> incorporate the proxy-prefix setting somehow. (Btw the 'logo_url' does
> seem to point to the correct location however.)
>
> Can someone suggest a fix?
>
> Thanks
>
> Peter
>

___________________________________________________________
Please keep all replies on the list by using "reply all"
in your mail client.  To manage your subscriptions to this
and other Galaxy lists, please use the interface at:
  https://lists.galaxyproject.org/

To search Galaxy mailing lists use the unified search at:
  http://galaxyproject.org/search/mailinglists/
| Threaded
Open this post in threaded view
|

Re: Broken logo 'src' in masthead for Galaxy 16.07 served from subdirectory

Peter Briggs
Hello Saskia

Thanks, yes that seems to have fixed it. Pretty obvious really!

I wonder, is your Galaxy instance also served from a subdirectory?

Thanks again,

Best wishes

Peter

On 08/12/16 13:21, Saskia Hiltemann wrote:

> hmm, I now remember having same thing when I first upgraded, I changed a
> line in galaxy.masthead.mako:
>
> --- a/templates/webapps/galaxy/galaxy.masthead.mako
> +++ b/templates/webapps/galaxy/galaxy.masthead.mako
> @@ -24,7 +24,7 @@
>              'terms_url'                 : app.config.get("terms_url", ""),
>              'allow_user_creation'       : app.config.allow_user_creation,
>              'logo_url'                  : h.url_for(app.config.get(
> 'logo_url', '/')),
> -            'logo_src'                  : h.url_for( app.config.get(
> 'logo_src', '../../../static/images/galaxyIcon_noText
> +            'logo_src'                  : h.url_for( app.config.get(
> 'logo_src', '/static/images/galaxyIcon_noText.png' )
>              'is_admin_user'             : trans.user_is_admin(),
>              'active_view'               : active_view,
>              'ftp_upload_dir'            :
> app.config.get("ftp_upload_dir",  None),
> @@ -78,4 +78,4 @@
>
> Does this help at all?
>
> Saskia
>
>
>
> On 08-12-16 14:04, Peter Briggs wrote:
>> Dear developers
>>
>> Since upgrading to release_16.07 I've noticed a broken link to the
>> masthead icon (i.e. the Galaxy logo 'galaxyIcon_noText.png') in our
>> local Galaxy installations, which are all served from subdirectories
>> of the webserver, e.g.
>>
>> https://centaurus.itservices.manchester.ac.uk/galaxy/
>>
>> The icon is visible when this URL is visited but appears to be broken
>> when using parts of Galaxy served from their own subdirectories e.g.
>> the login page (under
>> https://centaurus.itservices.manchester.ac.uk/galaxy/user/login?...)
>> or the admin interface
>> (https://centaurus.itservices.manchester.ac.uk/galaxy/admin).
>>
>> At the top level the logo <img> "src" is points correctly to
>> "/galaxy/static/images/galaxyIcon_noText.png"; in the subdirs
>> (users,admin etc) it points to
>> "../../../static/images/galaxyIcon_noText.png" (which cannot be loaded).
>>
>> As far as I can work out, in 16.07 the "src" location is generated
>> from templates/webapps/galaxy/galaxy.masthead.mako, but takes its
>> value from the 'logo_src' parameter that is set in
>> lib/galaxy/managers/configuration.py:
>>
>> ...
>>     # TODO: this doesn't seem right
>>    'logo_url'                  : lambda i, k, **c: self.url_for(
>> i.get( k, '/' ) ),
>>    'logo_src'                  : lambda i, k, **c: self.url_for(
>> '/static/images/galaxyIcon_noText.png' ),
>> ...
>>
>> However I have no idea how to try and fix it - presumably it needs to
>> incorporate the proxy-prefix setting somehow. (Btw the 'logo_url' does
>> seem to point to the correct location however.)
>>
>> Can someone suggest a fix?
>>
>> Thanks
>>
>> Peter
>>
>

--
Peter Briggs [hidden email]
Bioinformatics Core Facility University of Manchester
B.1083 Michael Smith Bldg Tel: (0161) 2751482
___________________________________________________________
Please keep all replies on the list by using "reply all"
in your mail client.  To manage your subscriptions to this
and other Galaxy lists, please use the interface at:
  https://lists.galaxyproject.org/

To search Galaxy mailing lists use the unified search at:
  http://galaxyproject.org/search/mailinglists/