"Resume Paused Jobs"

classic Classic list List threaded Threaded
3 messages Options
Reply | Threaded
Open this post in threaded view
|

"Resume Paused Jobs"

Björn Grüning-3
Hi,

can anyone confirm that "Resume Paused Jobs" on crashed tools is broken
in the latest Galaxy release?

Thanks,
Bjoern
___________________________________________________________
Please keep all replies on the list by using "reply all"
in your mail client.  To manage your subscriptions to this
and other Galaxy lists, please use the interface at:
  http://lists.bx.psu.edu/

To search Galaxy mailing lists use the unified search at:
  http://galaxyproject.org/search/mailinglists/
Reply | Threaded
Open this post in threaded view
|

Re: "Resume Paused Jobs"

John Chilton-4
I can in fact confirm I broke that. It needs to be conditionally
turned off in some cases now and I had the logic for when it is
display and when not appears to be inverted from what it should be
somehow.

Following patch fixes it for me:

diff --git a/static/scripts/galaxy.tools.js b/static/scripts/galaxy.tools.js
index 91b0597..2fa9ade 100644
--- a/static/scripts/galaxy.tools.js
+++ b/static/scripts/galaxy.tools.js
@@ -110,9 +110,9 @@ define([ "libs/underscore", "mvc/tools" ],
function( _, Tools ) {
         enableSelectBy: function( enableIndex, onValue ) {
             var selectionType = SELECTION_TYPE[onValue];
             if(selectionType["allow_remap"]) {
-                $("div#remap-row").css("display", "none");
-            } else {
                 $("div#remap-row").css("display", "inherit");
+            } else {
+                $("div#remap-row").css("display", "none");
             }
             this.formRow().find( "i" ).each(function(index, iElement) {
                 if(index == enableIndex) {

Will open a stable branch bug fix pull request shortly. Very sorry about that.

-John


On Sat, Jun 7, 2014 at 12:04 PM, Björn Grüning
<[hidden email]> wrote:

> Hi,
>
> can anyone confirm that "Resume Paused Jobs" on crashed tools is broken in
> the latest Galaxy release?
>
> Thanks,
> Bjoern
> ___________________________________________________________
> Please keep all replies on the list by using "reply all"
> in your mail client.  To manage your subscriptions to this
> and other Galaxy lists, please use the interface at:
>  http://lists.bx.psu.edu/
>
> To search Galaxy mailing lists use the unified search at:
>  http://galaxyproject.org/search/mailinglists/

___________________________________________________________
Please keep all replies on the list by using "reply all"
in your mail client.  To manage your subscriptions to this
and other Galaxy lists, please use the interface at:
  http://lists.bx.psu.edu/

To search Galaxy mailing lists use the unified search at:
  http://galaxyproject.org/search/mailinglists/
Reply | Threaded
Open this post in threaded view
|

Re: "Resume Paused Jobs"

Björn Grüning-3
No problem John, thanks for fixing it so fast!

Am 07.06.2014 19:25, schrieb John Chilton:

> I can in fact confirm I broke that. It needs to be conditionally
> turned off in some cases now and I had the logic for when it is
> display and when not appears to be inverted from what it should be
> somehow.
>
> Following patch fixes it for me:
>
> diff --git a/static/scripts/galaxy.tools.js b/static/scripts/galaxy.tools.js
> index 91b0597..2fa9ade 100644
> --- a/static/scripts/galaxy.tools.js
> +++ b/static/scripts/galaxy.tools.js
> @@ -110,9 +110,9 @@ define([ "libs/underscore", "mvc/tools" ],
> function( _, Tools ) {
>           enableSelectBy: function( enableIndex, onValue ) {
>               var selectionType = SELECTION_TYPE[onValue];
>               if(selectionType["allow_remap"]) {
> -                $("div#remap-row").css("display", "none");
> -            } else {
>                   $("div#remap-row").css("display", "inherit");
> +            } else {
> +                $("div#remap-row").css("display", "none");
>               }
>               this.formRow().find( "i" ).each(function(index, iElement) {
>                   if(index == enableIndex) {
>
> Will open a stable branch bug fix pull request shortly. Very sorry about that.
>
> -John
>
>
> On Sat, Jun 7, 2014 at 12:04 PM, Björn Grüning
> <[hidden email]> wrote:
>> Hi,
>>
>> can anyone confirm that "Resume Paused Jobs" on crashed tools is broken in
>> the latest Galaxy release?
>>
>> Thanks,
>> Bjoern
>> ___________________________________________________________
>> Please keep all replies on the list by using "reply all"
>> in your mail client.  To manage your subscriptions to this
>> and other Galaxy lists, please use the interface at:
>>   http://lists.bx.psu.edu/
>>
>> To search Galaxy mailing lists use the unified search at:
>>   http://galaxyproject.org/search/mailinglists/
___________________________________________________________
Please keep all replies on the list by using "reply all"
in your mail client.  To manage your subscriptions to this
and other Galaxy lists, please use the interface at:
  http://lists.bx.psu.edu/

To search Galaxy mailing lists use the unified search at:
  http://galaxyproject.org/search/mailinglists/